Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to enable buffering by default for UDS connections #244

Open
imsodin opened this issue Jan 24, 2023 · 0 comments
Open

Request to enable buffering by default for UDS connections #244

imsodin opened this issue Jan 24, 2023 · 0 comments

Comments

@imsodin
Copy link

imsodin commented Jan 24, 2023

I got a lot of the congestion errors, which are mentioned in the readme. To resolve those, I didn't need to change any system settings like suggested in the linked section there, just enabling buffering in hot-shots solved it. Datadog agent by default has a 8KiB buffer and recommends using buffering at clients (https://docs.datadoghq.com/developers/dogstatsd/high_throughput/?#enable-buffering-on-your-client), so I used that value for maxBufferSize. Unless there are any downsides, it seems like the user experience would be improved by making that the new default for UDS. Or if that's a problem with other servers/agent than datadog, I'd suggest to first recommend enabling the buffer in the readme and only if that doesn't help refer to the section currently linked about system settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant