New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asyncTimer consumes errors and return values #234

Open

luke-lacroix-healthy opened this issue Sep 26, 2022 · 0 comments

luke-lacroix-healthy commented Sep 26, 2022 •

edited

Loading

The implementation of asyncTimer causes it to consume errors and return values.

Here is a Jest test that shows the failure:

const error = Promise.reject(new Error());
const value = Promise.resolve('value');

await expect(metrics.asyncTimer(() => error)).rejects.toThrow(Error);
await expect(metrics.asyncTimer(() => value)).resolves.toEqual('value');

Neither tests will pass as the result of BOTH the rejection and the successful run will return the result of the timing function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment