Replace PUBLIC_MODULUS_MAX_LEN with VERIFY_PUBLIC_MODULUS_MAX_LEN.

`VERIFY_PUBLIC_MODULUS_MAX_LEN` is measured in bytes, whereas
`PUBLIC_MODULUS_MAX_LEN` was measured in bits.

Author: briansmith

src/rsa/padding.rs

@@ -290,7 +290,7 @@ impl Verification for PSS {
         }
 
         // Step 7.
-        let mut db = [0u8; super::PUBLIC_MODULUS_MAX_LEN / 8];
+        let mut db = [0u8; super::VERIFY_PUBLIC_MODULUS_MAX_LEN];
         let db = &mut db[..metrics.db_len];
 
         try!(mgf1(self.digest_alg, h_hash.as_slice_less_safe(), db));

src/rsa/rsa.rs

@@ -24,8 +24,8 @@ pub use self::padding::{RSA_PKCS1_SHA256, RSA_PKCS1_SHA384, RSA_PKCS1_SHA512,
                         RSA_PSS_SHA256, RSA_PSS_SHA384, RSA_PSS_SHA512};
 
 
-// Maximum RSA modulus size supported for signature verification (in bits).
-const PUBLIC_MODULUS_MAX_LEN: usize = 8192;
+// Maximum RSA modulus size supported for signature verification (in bytes).
+const VERIFY_PUBLIC_MODULUS_MAX_LEN: usize = 8192 / 8;
 
 /// Parameters for RSA verification.
 pub struct RSAParameters {

src/rsa/verification.rs

@@ -15,8 +15,8 @@
 /// RSA PKCS#1 1.5 signatures.
 
 use {bssl, c, error, private, signature};
-use super::{BIGNUM, PositiveInteger, PUBLIC_MODULUS_MAX_LEN, RSAParameters,
-            parse_public_key};
+use super::{BIGNUM, PositiveInteger, VERIFY_PUBLIC_MODULUS_MAX_LEN,
+            RSAParameters, parse_public_key};
 use untrusted;
 
 
@@ -110,7 +110,7 @@ pub fn verify_rsa(params: &RSAParameters,
                   msg: untrusted::Input, signature: untrusted::Input)
                   -> Result<(), error::Unspecified> {
     let signature = signature.as_slice_less_safe();
-    let mut decoded = [0u8; (PUBLIC_MODULUS_MAX_LEN + 7) / 8];
+    let mut decoded = [0u8; VERIFY_PUBLIC_MODULUS_MAX_LEN];
     if signature.len() > decoded.len() {
         return Err(error::Unspecified);
     }
@@ -121,7 +121,8 @@ pub fn verify_rsa(params: &RSAParameters,
     try!(bssl::map_result(unsafe {
         GFp_rsa_public_decrypt(decoded.as_mut_ptr(), decoded.len(), n.as_ref(),
                                e.as_ref(), signature.as_ptr(), signature.len(),
-                               params.min_bits, PUBLIC_MODULUS_MAX_LEN)
+                               params.min_bits,
+                               VERIFY_PUBLIC_MODULUS_MAX_LEN * 8)
     }));
 
     untrusted::Input::from(decoded).read_all(