Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversations are not saved or stored as notes #944

Open
Bugsia opened this issue Dec 29, 2024 · 13 comments
Open

Conversations are not saved or stored as notes #944

Bugsia opened this issue Dec 29, 2024 · 13 comments

Comments

@Bugsia
Copy link

Bugsia commented Dec 29, 2024

My conversations are not stored as notes and in the smart Chat UI nothing happens when I press the button to open the conversation note.
My conversations also disappear, when I restart obsidian.

The only error in the developer console, related to the smartConnections plugin is this one:
Uncaught TypeError: opts.handle_chat_input_keydown is not a function at SmartView.handle_chat_input_keydown (plugin:smart-connections:13988:8) at HTMLTextAreaElement.eval (plugin:smart-connections:13942:77)

@Olivmamman
Copy link

same issue for me

@zackheil
Copy link

This appears to have been a deliberate decision to change how this works. Digging around, conversations are now stored in a different location as json files at: .smart-env/smart_threads.

@brianpetro
Copy link
Owner

@zackheil is correct that the latest version deliberately left out saving as notes.

The architecture does support re-adding this feature in the future, however, given the nature of open-source projects like this, often the best way for me to figure out if a feature is being used is to simply remove it and see if anyone notices.

There are still some bugs in the saving process, some have already been fixed in the early-release version.

If there are any specific features wrt to saving chats as notes, I am interested in hearing them so we can build the best implementation when it gets re-added in the future.

Thanks for bringing the issue to my attention
🌴

@zackheil
Copy link

Respectfully, my 2 cents as someone that used the feature myself: I really wish you wouldn't do that and respect semver wrt features/breaking changes. Complaints via GH issues is not a good telemetry model and it's just frustrating to see features disappear without notice, especially when the removal is half-baked and there are still UI elements dedicated to triggering said removed feature. It just gives the appearance that the plugin is unstable and buggy. I'm all for brainstorming different methods to engage with the user-base on feature use and interest in non-invasive ways, but please don't do gotchas like this.

@brianpetro
Copy link
Owner

@zackheil The Community Lean Coffee meetings were set up by a community member and have been a great help in further aligning the project with users willing to participate. We're still working out the schedule for the next year, but I encourage you to join.

I wrote about my thoughts on the subject stability vs innovation here.

While I am constantly working on things to improve long-term stability (in spite of how it may look, I could talk at length about the things being done in this regard), my primary mission remains, "empowering individuals with the latest technology," and that means that sometimes I have to be unapologetic about breaking things. And it's true that may turn people away in the short-term. But my unimpeded ability to innovate is what I see as making the project something that will thrive in the long-term.

🌴

@Bugsia
Copy link
Author

Bugsia commented Jan 1, 2025

@brianpetro

If there are any specific features wrt to saving chats as notes, I am interested in hearing them so we can build the best implementation when it gets re-added in the future.

I think saving the chats as notes is better than in .json files.

For example this automatically enables the user to search for old conversations. When using ChatGPT I often only remember parts of the past conversation and not the title, meaning I have to go through every one to find the one I need.
So when the chats are stored as notes users can simply use existing search tools.

Also, are untitled conversations saved? It seems like currently they are not, but I think it would be nice, if they get saved, when a message is sent. Maybe with the name being parts of the first user message.
Because I already see myself forgetting naming all the time, when I just ask a quick question and then searching for it later.

@mimkorn
Copy link

mimkorn commented Jan 5, 2025

Agree with @zackheil in the sense that I am clicking on "open note" button and it's not doing anything ending up looking for an issue. Removing the button or throwing a small alert/notification would remove the buggy impression.

@micaelarealign
Copy link

micaelarealign commented Jan 16, 2025

"the best way for me to figure out if a feature is being used is to simply remove it and see if anyone notices."

???

Who even does that?

@zackheil
Copy link

zackheil commented Jan 17, 2025

I appreciate the vision and passion you have for this project. I've found it pretty helpful here and there, but things like this sour the experience. It’s not so much that you removed the feature, but that you did so while presenting it as a simple minor/patch release.

While I understand and respect your need for freedom to experiment, I want to reiterate what I initially said: it would mean a lot to users like me if you could at least follow semantic versioning.

Fixes should increment the patch, new or enhanced features should increment the minor version, but if you’re removing something that people might be relying on, that’s a breaking change and should be reflected in the versioning with a major bump. This is especially important since Obsidian doesn’t aggregate release notes across versions, so users can’t easily catch changes they need to be aware of when updating.

@rmccorkl
Copy link

rmccorkl commented Jan 20, 2025

In my opinion, if there is a decision to transition chat history to a JSON format stored in a hidden folder, several key requirements and issues need to be addressed:

  1. Migration Path: A clear and seamless migration process must be established to move existing chat notes to the new JSON format and location. And/Or maintain backward compatibility.

  2. Management Capabilities: The system should provide an intuitive mechanism for managing historical chat data (e.g., viewing, deleting, or exporting). Previously, chat notes were treated as standard files in a user-specified folder, making them easy to locate and manage like any other note. With the proposed shift to a hidden folder and JSON format, users would be forced to navigate a concealed directory within the application or file system, which is not ideal and could lead to frustration or confusion. It’s essential to avoid relying on hidden file locations within the Vault for such operations, as this approach diminishes transparency and user control.

  3. User Interface Gaps: The current implementation has critical limitations. Selected historical chats in the new JSON format are not displayed in the UI, nor can they be deleted directly through the interface, renaming deletes content(json). This lack of functionality creates significant usability issues and prevents users from managing their chat history effectively. Adding UI support for these actions is imperative for maintaining user satisfaction and ease of use.

  4. Also as the location is now hidden its not accessible by normal note search functions of the vault.

By addressing these requirements, the transition to a JSON-based hidden folder system can be implemented effectively while minimizing disruptions and enhancing user control over chat history.

@micaelarealign
Copy link

micaelarealign commented Jan 20, 2025

Brian just uses chatGPT to code which often removes things when you don't pay attention. So this is not surprising. I have moved away from using this extension for many reasons that can probably be traced back to this unfortunate fact. Version two has been a
colossal, unusable and unstable mess since its release, and Brian has introduced a paid tier profiting off the generous contributions of everyone here (while using a highly selective subset of reviews mostly written by users of v1 to advertise for this service). I refuse to continue supporting a developer who will just take our contributions to turn this into a paid product, and bans people who point out that things are constantly broken.

@brianpetro
Copy link
Owner

Brian just uses chatGPT to code which often removes things when you don't pay attention

This is simply not the case with why things are removed.

While I can't afford to respond to every gripe on GitHub, as suggested in #944 (comment) , please join the community chat so we can discuss. I assure you, my intentions behind my actions are backed up with significant reasoning and I don't make breaking decisions lightly.

Also, supporters of the project have access to a private chat where I prioritize responding. So if you are actually a supporter, please join the chat so I can better prioritize addressing your concerns 😊 🌴

@brianpetro
Copy link
Owner

@micaelarealign addressing your edited messages since it changes the context of my previous reply:

Image

I've only ever blocked a single person on GitHub, and I both tweeted and made an issue about it. I suggest checking it out #875 (comment)

Also, the README, where the testimonials are published, is very outdated (something I hope to have resolved soon). And publishing a list of testimonials was an urgent priority when I was trying to get the project off the ground. But the lack of recently published testimonials is far from representative of the reality, which is that I receive positive testimonials everyday. The project is fortunate to be supported by users, and each tell me why they support the project (a requirement to become a supporter). I've been told everything from how Smart Connections enables businesses to how it helped someone gain the medical diagnosis they needed to get better.

Once again, I invite you to join our Community Lean Coffee chats. The stability issue is often discussed and community members seem to quickly come to understand why things break and how it aligns with the vision I have that will make the issues in the near term all worthwhile 🌴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants