Replies: 1 comment
-
@delano Thanks for your interest in Smart Connections and contributing to the project. In addition to "VecLite," Smart Connections is being refactored into modules that will consist of the "AI" logic, leaving this Smart Connections plugin to represent the Obsidian-specific pieces. At this point, I do intend to release all of the modules. However, the intent behind Smart Connections was to contribute to the Obsidian community, and not necessarily the open-source community (though that would be great, too). Regarding the license, it's purposefully restrictive to give me options as I decide how to proceed. In the meantime, the best way to contribute would be detailed feature requests, including code snippets if you're so inclined. I appreciate your feedback and will be happy to consider any additional insights you might be able to provide. Thanks for helping make Smart Connections the best it can be, |
Beta Was this translation helpful? Give feedback.
-
Hey, great work on this plugin. I use it daily to navigate my vaults. I'm looking into contributing and have a couple questions.
Context
There are references in the repo to
vec_lite/vec_lite.js
andVecLite
/VecLite2
classes:package.json
obsidian-smart-connections/package.json
Lines 31 to 33 in d34f90d
dist/main.js
obsidian-smart-connections/dist/main.js
Lines 6 to 11 in d34f90d
src/index.js
obsidian-smart-connections/src/index.js
Lines 1 to 2 in d34f90d
obsidian-smart-connections/src/index.js
Lines 197 to 199 in d34f90d
The repo doesn't appear to include the original source files that are being referenced here though (in either javascript or typescript).
Contributing
This presents a challenge when it comes to submitting code contributions. We're only able to work with the js files generated during a build but not directly with the source. This must present a challenge when accepting PRs too where presumably you'd need to copy the changes over manually, re-build, and then push the changes to the generated files to make them available in the repo.
If it's intentional (which is totally fine), you may want to look into using an alternative license since GPLv3 requires include the original source. If they just haven't been committed yet (which is also totally fine), please do so myself and others can contribute work to the code itself 🙏
Beta Was this translation helpful? Give feedback.
All reactions