Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/02_module_pod_output.t may fail if run as root #44

Open
syyhao1994 opened this issue Feb 4, 2020 · 3 comments
Open

t/02_module_pod_output.t may fail if run as root #44

syyhao1994 opened this issue Feb 4, 2020 · 3 comments
Assignees
Labels
Priority: high work on this first Status: awaiting cpan testers waiting for results from CPAN Testers Status: stalled something is blocking progress Type: test bug an existing test is broken

Comments

@syyhao1994
Copy link

As i described in the title, make test failed when i am a root user.
https://rt.cpan.org/Public/Bug/Display.html?id=127153

@briandfoy
Copy link
Owner

I've just taken over the maintenance of Pod::Perldoc, so I'll look into this. I know it's years old, and it might take me a bit to catch up.

@briandfoy briandfoy added Status: needs verification issue needs to be verified Priority: low get to this whenever Type: test bug an existing test is broken labels Dec 5, 2023
briandfoy added a commit that referenced this issue Dec 6, 2023
@briandfoy
Copy link
Owner

The RT ticket mentions this happening in a docker container where the file the tests try to use are under /root. perldoc drops permissions unless you run it with -U or -F. This turns off the security features, which is not what we want to do in testing. Part of the problem is that someone can specify the formatter in an environment variable.

This is working as designed, but I can skip the test if the real or effective UID are 0.

Also, you can trust that the tests work and install with cpan -T or cpanm --notest.

I'm uploading 3.28_01 to see if skipping the root cases will solve the CPAN Testers issues.

@briandfoy briandfoy added Status: awaiting cpan testers waiting for results from CPAN Testers Priority: high work on this first and removed Status: needs verification issue needs to be verified Priority: low get to this whenever labels Dec 6, 2023
@briandfoy briandfoy self-assigned this Dec 6, 2023
@briandfoy briandfoy added the Status: stalled something is blocking progress label Dec 8, 2023
@briandfoy
Copy link
Owner

Huh, the CPAN Testers page has not updated since I uploaded the dev version of the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: high work on this first Status: awaiting cpan testers waiting for results from CPAN Testers Status: stalled something is blocking progress Type: test bug an existing test is broken
Projects
None yet
Development

No branches or pull requests

2 participants