Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default values for metric/optimizer #5

Open
mstimberg opened this issue Sep 3, 2019 · 1 comment
Open

Default values for metric/optimizer #5

mstimberg opened this issue Sep 3, 2019 · 1 comment

Comments

@mstimberg
Copy link
Member

[Refers to the current state of PR #2]

Currently, SpikeFitter and TraceFitter require the specification of a metric and an optimizer, but we could have default values (MSEMetric for TraceFitter, GammaFactor for SpikeFitter, NevergradOptimizer for both?).
@romainbrette
Copy link
Member

This seems reasonable.

@mstimberg mstimberg mentioned this issue Apr 5, 2021
Merged
eslam69 pushed a commit to eslam69/brian2modelfitting that referenced this issue Apr 7, 2021
Add default values for metric/optimizer in Fitters (brian-team#5) (br…
a109617 
…ian-team#41)
eslam69 pushed a commit to eslam69/brian2modelfitting that referenced this issue Apr 7, 2021
Add tests for default optimizer/metric (brian-team#5)
0a0be47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mstimberg @romainbrette