ok actually lets refactor to file rn

Author: briaguya-ai

src/resource/ResourceLoader.cpp

@@ -93,12 +93,24 @@ std::shared_ptr<IResource> ResourceLoader::LoadResource(std::shared_ptr<File> fi
 
 
 
-    auto factory = GetFactory(fileToLoad->InitData->IsXml) mFactories[fileToLoad->InitData->Type];
+    auto factory = GetFactory(fileToLoad->InitData->Format, fileToLoad->InitData->Type, fileToLoad->InitData->ResourceVersion);
     if (factory == nullptr) {
         SPDLOG_ERROR("Failed to load resource: Factory does not exist ({} - {})", fileToLoad->InitData->Type,
                      fileToLoad->InitData->Path);
     }
 
+    // todo: figure out a better way to handle this
+    // probably just have it so ReadReasource takes in the pointer to fileToLoad directly
+    switch (fileToLoad->InitData->Format) {
+        case RESOURCE_FORMAT_BINARY:
+            factory->ReadResource(fileToLoad->InitData, std::make_shared<BinaryReaderBox>())
+        case RESOURCE_FORMAT_XML:
+
+        default:
+            SPDLOG_ERROR("invalid resource format {}", fileToLoad->InitData->Format);
+            return nullptr;
+    }
+
     if (fileToLoad->InitData->IsXml) {
         if (fileToLoad->XmlDocument == nullptr) {
             SPDLOG_ERROR("Failed to load resource: File has no XML document ({} - {})", fileToLoad->InitData->Type,

src/resource/archive/Archive.cpp

@@ -173,7 +173,7 @@ std::shared_ptr<ResourceInitData> Archive::CreateDefaultResourceInitData() {
     resourceInitData->Type = static_cast<uint32_t>(ResourceType::None);
     resourceInitData->ResourceVersion = -1;
     resourceInitData->IsCustom = false;
-    resourceInitData->IsXml = false;
+    resourceInitData->Format = RESOURCE_FORMAT_BINARY;
     resourceInitData->ByteOrder = Endianness::Native;
     return resourceInitData;
 }
@@ -230,7 +230,7 @@ std::shared_ptr<ResourceInitData> Archive::ReadResourceInitDataXml(const std::st
 
     // XML
     resourceInitData->IsCustom = true;
-    resourceInitData->IsXml = true;
+    resourceInitData->Format = RESOURCE_FORMAT_XML;
 
     auto root = document->FirstChildElement();
     resourceInitData->Type = Context::GetInstance()->GetResourceManager()->GetResourceLoader()->GetResourceType(root->Name());

src/resource/factory/DisplayListFactory.cpp

@@ -192,7 +192,7 @@ std::shared_ptr<IResource> ResourceFactoryXMLDisplayListV0::ReadResource(std::sh
 
     auto dl = std::make_shared<DisplayList>(initData);
 
-    auto child = reader->FirstChildElement();
+    auto child = reader->FirstChildElement()->FirstChildElement();
 
     while (child != nullptr) {
         std::string childName = child->Name();

src/resource/factory/VertexFactory.cpp

@@ -58,7 +58,7 @@ std::shared_ptr<IResource> ResourceFactoryXMLVertexV0::ReadResource(std::shared_
 
     auto vertex = std::make_shared<Vertex>(initData);
 
-    auto child = reader->FirstChildElement();
+    auto child = reader->FirstChildElement()->FirstChildElement();
 
     while (child != nullptr) {
         std::string childName = child->Name();

src/resource/readerbox/ReaderBox.h

@@ -1,5 +1,8 @@
 #pragma once
 
 namespace LUS {
-class ReaderBox {};
+class ReaderBox {
+    public:
+        virtual ~ReaderBox() = 0; 
+};
 } // namespace LUS

src/resource/readerbox/XMLReaderBox.h

@@ -5,17 +5,17 @@
 namespace LUS {
 class XMLReaderBox : public ReaderBox {
     public:
-        XMLReaderBox(std::shared_ptr<tinyxml2::XMLElement> reader) {
+        XMLReaderBox(std::shared_ptr<tinyxml2::XMLDocument> reader) {
             mReader = reader;
         };
-        std::shared_ptr<tinyxml2::XMLElement> GetReader() {
+        std::shared_ptr<tinyxml2::XMLDocument> GetReader() {
             return mReader;
         };
         ~XMLReaderBox() {
             mReader = nullptr;
         };
 
     private:
-        std::shared_ptr<tinyxml2::XMLElement> mReader;
+        std::shared_ptr<tinyxml2::XMLDocument> mReader;
 };
 } // namespace LUS