i think this is a somewhat reasonable way for these to look?

Author: briaguya-ai

src/resource/factory/TextureFactory.cpp

@@ -21,45 +21,32 @@ std::shared_ptr<IResource> ResourceFactoryBinaryTextureV0::ReadResource(std::sha
 
     auto texture = std::make_shared<Texture>(initData);
 
-
-
-    std::shared_ptr<ResourceVersionFactory> factory = nullptr;
-
-    switch (resource->GetInitData()->ResourceVersion) {
-        case 0:
-            factory = std::make_shared<TextureFactoryV0>();
-            break;
-        case 1:
-            factory = std::make_shared<TextureFactoryV1>();
-            break;
-    }
-
-    if (factory == nullptr) {
-        SPDLOG_ERROR("Failed to load Texture with version {}", resource->GetInitData()->ResourceVersion);
-        return nullptr;
-    }
-
-    factory->ParseFileBinary(reader, resource);
-
-    return resource;
-}
-
-void TextureFactoryV0::ParseFileBinary(std::shared_ptr<BinaryReader> reader, std::shared_ptr<IResource> resource) {
-    // std::shared_ptr<Texture> texture = std::static_pointer_cast<Texture>(resource);
-    ResourceVersionFactory::ParseFileBinary(reader, texture);
-
     texture->Type = (TextureType)reader->ReadUInt32();
     texture->Width = reader->ReadUInt32();
     texture->Height = reader->ReadUInt32();
     texture->ImageDataSize = reader->ReadUInt32();
     texture->ImageData = new uint8_t[texture->ImageDataSize];
 
     reader->Read((char*)texture->ImageData, texture->ImageDataSize);
+
+    return texture;
 }
 
-void TextureFactoryV1::ParseFileBinary(std::shared_ptr<BinaryReader> reader, std::shared_ptr<IResource> resource) {
-    std::shared_ptr<Texture> texture = std::static_pointer_cast<Texture>(resource);
-    ResourceVersionFactory::ParseFileBinary(reader, texture);
+std::shared_ptr<IResource> ResourceFactoryBinaryTextureV1::ReadResource(std::shared_ptr<ResourceInitData> initData,
+                                                        std::shared_ptr<ReaderBox> readerBox) {
+    auto binaryReaderBox = std::dynamic_pointer_cast<BinaryReaderBox>(readerBox);
+    if (binaryReaderBox == nullptr) {
+        SPDLOG_ERROR("ReaderBox must be a BinaryReaderBox.");
+        return nullptr;
+    }
+
+    auto reader = binaryReaderBox->GetReader();
+    if (reader == nullptr) {
+        SPDLOG_ERROR("null reader in box.");
+        return nullptr;
+    }
+
+    auto texture = std::make_shared<Texture>(initData);
 
     texture->Type = (TextureType)reader->ReadUInt32();
     texture->Width = reader->ReadUInt32();
@@ -71,5 +58,7 @@ void TextureFactoryV1::ParseFileBinary(std::shared_ptr<BinaryReader> reader, std
     texture->ImageData = new uint8_t[texture->ImageDataSize];
 
     reader->Read((char*)texture->ImageData, texture->ImageDataSize);
+
+    return texture;
 }
 } // namespace LUS