Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnurlw not using http on .onion sites #977

Closed
dipunm opened this issue Sep 4, 2022 · 15 comments
Closed

lnurlw not using http on .onion sites #977

dipunm opened this issue Sep 4, 2022 · 15 comments
Assignees

Comments

@dipunm
Copy link

dipunm commented Sep 4, 2022

as per https://github.com/fiatjaf/lnurl-rfc/blob/luds/17.md

I did a quick test using nfc and saw that it tried to use https on my onion url.

@dipunm
Copy link
Author

dipunm commented Sep 4, 2022

I was using orbot to make breez be able to make tor requests, so in retrospect, breez has no official support for tor, but it would be cool if it did at least this much.

@kingonly
Copy link
Member

kingonly commented Sep 5, 2022

Did you do this?
https://t.me/lnurl/32585

@dipunm
Copy link
Author

dipunm commented Sep 5, 2022

Yes

@dipunm
Copy link
Author

dipunm commented Sep 5, 2022

To be clearer, lnurlw:// and other scheme's are converted to https, but when .onion is used, it should use http

@kingonly
Copy link
Member

kingonly commented Sep 5, 2022

Gotcha. We might need your help with a test site, could you please provide an email? @ademar111190 please follow up.

@dipunm
Copy link
Author

dipunm commented Sep 5, 2022

Is there a way to give an email privately? If you provide your email, I can email you... I don't want my email on this public forum.

@kingonly
Copy link
Member

kingonly commented Sep 5, 2022

Sure, please send a note to: [email protected]

@ademar111190
Copy link
Collaborator

I found the root of the problem, and the fix is here fiatjaf/go-lnurl#13
once it is merged on the go-lnurl library, we need to update it on breez lib to have the fix on our app.

@dipunm
Copy link
Author

dipunm commented Sep 16, 2022

Nice

@dipunm
Copy link
Author

dipunm commented Sep 24, 2022

Looks like it's merged 👀👀

@ademar111190
Copy link
Collaborator

Yeap 🥳

I'm waiting for a new release of the lib including the fix, 1.12.0 or 1.11.3

@dipunm
Copy link
Author

dipunm commented Oct 3, 2022

@ademar111190
Copy link
Collaborator

Excellent, I'll update it on our library asap, thank you @dipunm

@kingonly
Copy link
Member

Merged to mobile. Will be released in our next update.

@kingonly
Copy link
Member

Should be fixed in latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants