-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lnurlw not using http on .onion sites #977
Comments
I was using orbot to make breez be able to make tor requests, so in retrospect, breez has no official support for tor, but it would be cool if it did at least this much. |
Did you do this? |
Yes |
To be clearer, lnurlw:// and other scheme's are converted to |
Gotcha. We might need your help with a test site, could you please provide an email? @ademar111190 please follow up. |
Is there a way to give an email privately? If you provide your email, I can email you... I don't want my email on this public forum. |
Sure, please send a note to: [email protected] |
I found the root of the problem, and the fix is here fiatjaf/go-lnurl#13 |
Nice |
Looks like it's merged 👀👀 |
Yeap 🥳 I'm waiting for a new release of the lib including the fix, |
Excellent, I'll update it on our library asap, thank you @dipunm |
Merged to mobile. Will be released in our next update. |
Should be fixed in latest |
as per https://github.com/fiatjaf/lnurl-rfc/blob/luds/17.md
I did a quick test using nfc and saw that it tried to use https on my onion url.
The text was updated successfully, but these errors were encountered: