Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to DiscountCT by Feb 2025 #625

Closed
dangeross opened this issue Dec 21, 2024 · 2 comments · Fixed by #637
Closed

Switch to DiscountCT by Feb 2025 #625

dangeross opened this issue Dec 21, 2024 · 2 comments · Fixed by #637
Assignees
Milestone

Comments

@dangeross
Copy link
Collaborator

See https://discord.com/channels/547454030801272832/656789435869954048/1319074210856964187

@dangeross dangeross added the high priority Should be prioritized over others label Dec 21, 2024
@roeierez
Copy link
Member

This explains the discount size for confidential transactions very well: https://github.com/ElementsProject/ELIPs/blob/main/elip-0200.mediawiki

We should also update our rust-elements crate to include the latest changes regarding the weight calculation for discounted transaction.
We also need to upgrade our liquid node to be able to relay such transactions

@roeierez roeierez added this to the v0.6.0 milestone Dec 24, 2024
@roeierez
Copy link
Member

We have the new liquid node that supports this deployed.
It seems now we need to:

  1. update our client to include the code for calculating the discounted size.
  2. Calculate the right fees accordingly and make sure when we use blockstream public node to broadcast the transaction it is minded and the swapper accepts it in zero conf swaps.

@roeierez roeierez modified the milestones: v0.6.0, Next Release Jan 7, 2025
@roeierez roeierez removed the high priority Should be prioritized over others label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants