Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsps2: Support extra_fee TLV #384

Open
JssDWt opened this issue Aug 7, 2023 · 1 comment
Open

lsps2: Support extra_fee TLV #384

JssDWt opened this issue Aug 7, 2023 · 1 comment

Comments

@JssDWt
Copy link
Contributor

JssDWt commented Aug 7, 2023 •
edited
Loading

As mentioned in https://github.com/BitcoinAndLightningLayerSpecs/lsp/blob/main/LSPS2/README.md#5--channel-opening-and-forwarding

In short: Htlcs should be inspected on the extra_fee field.
@JssDWt JssDWt mentioned this issue Aug 7, 2023
Open
7 tasks
@JssDWt JssDWt self-assigned this Sep 29, 2023
@JssDWt JssDWt removed their assignment Oct 23, 2023
@JssDWt
Copy link
Contributor Author

JssDWt commented Oct 23, 2023 •
edited
Loading

There is noextra_fee TLV support in the LSP yet. So this issue will be deferred.

Note that it might be good to check for the extra_fee TLV inside the signer itself, rather than in a Greenlight plugin.

@JssDWt JssDWt changed the title lsps2: Ensure lsp htlcs are correct lsps2: Support extra_fee TLV Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JssDWt