Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move New Tab button position in vertical tabs #42533

Open
3 of 6 tasks
rebron opened this issue Nov 26, 2024 · 2 comments · May be fixed by brave/brave-core#27117
Open
3 of 6 tasks

Move New Tab button position in vertical tabs #42533

rebron opened this issue Nov 26, 2024 · 2 comments · May be fixed by brave/brave-core#27117
Assignees
Labels
feature/vertical-tabs OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Nov 26, 2024

Description

In vertical tabs mode, the New Tab button is fixed to the bottom left of the browser. To match horizontal tabs mode and other vertical tab mode implementations in other browsers, the New Tab button placement should be right below the last tab in the vertical tabs list.

There should be a separator between the last tab in the vertical tabs mode list and the New Tab button.

When the vertical tabs mode list is full and requires a scroll, the New Tab button should then be fixed at the bottom left of the screen like the current implementation.

Steps to reproduce

  1. Launch into vertical tabs mode.
  2. Note placement of New Tab button position.

Actual result

Image

Expected result

Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.75.x or earlier

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 26, 2024
@rebron rebron moved this to On Deck in Front End Nov 26, 2024
@humidmist
Copy link

Yes, it's really needed.

@simonhong simonhong self-assigned this Jan 6, 2025
@rebron rebron moved this from On Deck to In progress in Front End Jan 8, 2025
@yulian5
Copy link

yulian5 commented Jan 9, 2025

That is a good request. However the main purpose of this button is to use it with the mouse. With horizontal tabs "New tab" button is located next to the bookmark bar and it's very convenient click on it and then select the page from bookmarks. With vertical tabs location of "New tab" at the bottom of tabs list is a total disaster. The current request makes it 50% better, I think. My proposal is to place "New tab" button just under the bar with "Minimize tabs" and "Search tabs" buttons:

Image

In this case mouse experience with vertical tabs will be very close to that with horizontal tabs with minimum mouse movements. We even can put "New tab" button between "Minimize tabs" and "Search tabs" buttons and save one line for tabs:

Image

But in this case we won't have "+" for new tab when tabs are minimized.

And the proposal with "New button" at the top is much easier to implement than at the bottom of the tab list with jumping out of it when tab list is full and scrolling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/vertical-tabs OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Status: In progress
4 participants