Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shred button displayed unnecessarily on certain screens #41671

Open
2 of 5 tasks
Uni-verse opened this issue Oct 16, 2024 · 0 comments · May be fixed by brave/brave-core#26049
Open
2 of 5 tasks

Shred button displayed unnecessarily on certain screens #41671

Uni-verse opened this issue Oct 16, 2024 · 0 comments · May be fixed by brave/brave-core#26049
Assignees
Labels
needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/iOS Fixes related to iOS browser functionality privacy/shred-feature Issues related to the Shred feature QA/Yes release-notes/exclude

Comments

@Uni-verse
Copy link
Contributor

Description

Shred button displayed unnecessarily on certain screens

These include:

  • Private Browsing opt in page
  • Synced tabs from other devices screen
Private tab Tabs from other devices
Image Image

Steps to reproduce

  1. New install
  2. Switch tabs to Private
  3. In normal tab mode, switch to "Tabs from other devices" after connecting to Sync chain (enable Sync tabs)

Actual result

  • Shred button is shown on Private tab screen which is unnecessary because there is nothing to shred
  • Shred button is shown on "Tabs from other devices" screen in tab view. Also unnecessary because shred button only affects tabs opened locally.

Expected result

Remove from these screens

Reproduces how often

Easily reproduced

Brave version

1.71 (112)

Device/iOS version

iPhone, iOS 18.0

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@Uni-verse Uni-verse added needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/iOS Fixes related to iOS browser functionality privacy/shred-feature Issues related to the Shred feature QA/Yes release-notes/exclude labels Oct 16, 2024
@StephenHeaps StephenHeaps self-assigned this Oct 16, 2024
@StephenHeaps StephenHeaps linked a pull request Oct 16, 2024 that will close this issue
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/iOS Fixes related to iOS browser functionality privacy/shred-feature Issues related to the Shred feature QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants