Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use server provided prompt for page summaries #41657

Open
6 tasks
nvonpentz opened this issue Oct 15, 2024 · 0 comments · May be fixed by brave/brave-core#26016
Open
6 tasks

Use server provided prompt for page summaries #41657

nvonpentz opened this issue Oct 15, 2024 · 0 comments · May be fixed by brave/brave-core#26016
Labels
browser-ai OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@nvonpentz
Copy link
Member

Description

We're still using the client side prompt for these - "Provide a concise list of up to 6 bullets on the most important points of the page". It is a little stale and the summaries aren't that great.

@LorenzoMinto added a different prompt to the server, and that is getting better results.

Since this is one of the easiest / most common ways to use Leo, we want to leave a good impression. Let's update the client to use the requestSummary event instead of a chatMessage with the client prompt, that way we use the server defined prompt for this case.

Steps to reproduce

n/a

Actual result

n/a

Expected result

n/a

Reproduces how often

Easily reproduced

Brave version (brave://version info)

n/a

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants