Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.chromium.chrome.browser.crypto_wallet.Utils.getProfile() should be moved to some common utils #41689

Open
AlexeyBarabash opened this issue Oct 17, 2024 · 0 comments

Comments

@AlexeyBarabash
Copy link
Contributor

AlexeyBarabash commented Oct 17, 2024

Description

because this method is used outside of crypto_wallet at many places:

src/brave/android/java/org/chromium/chrome/browser/app/helpers/ImageLoader.java
src/brave/android/java/org/chromium/chrome/browser/misc_metrics/MiscAndroidMetricsFactory.java
src/brave/android/java/org/chromium/chrome/browser/shields/FilterListServiceFactory.java
src/brave/android/java/org/chromium/chrome/browser/shields/UrlSanitizerServiceFactory.java
src/brave/android/java/org/chromium/chrome/browser/webcompat_reporter/WebcompatReporterServiceFactory.java

from brave/brave-core#25688 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant