Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BraveClassVisitor ensure the patch was applied #41548

Open
AlexeyBarabash opened this issue Oct 10, 2024 · 0 comments
Open

Make BraveClassVisitor ensure the patch was applied #41548

AlexeyBarabash opened this issue Oct 10, 2024 · 0 comments
Labels
dev-concern

Comments

@AlexeyBarabash
Copy link
Contributor

Description

Follow up from brave/brave-core#25923 (comment)

BraveClassVisitor so it will warn or even fail the build if the specified modification hadn't triggered.

Advantages:

  • we will be able to see if we missing the jar-file
  • we will be able to see if deleteField/deleteMethod didn't do any changes, so probably the field / method was removed from the upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexeyBarabash