Ctrl+Shift+B changes settings unpredictably

[Catishere]

Description

If your bookmarks were set to appear only on new tabs and you press Ctrl+Shift+B twice the bookmarks are hidden on every tab including New tab

Steps to Reproduce

1. Set "Appearance > Show bookmarks" to "Only on the new tab page"
2. Press "Ctrl + Shift + B" twice.

Actual result:

The "Appearance > Show bookmarks" setting is set to "Never"

Expected result:

The "Appearance > Show bookmarks" setting is set to "Only on the new tab page"

Reproduces how often:

Always

Desktop Brave version:

Version 1.49.128 Chromium: 111.0.5563.110 (Official Build) (64-bit)

Version/Channel Information:

IDK, older versions didn't do this

Other Additional Information:

• Is the issue reproducible on the latest version of Chrome?
  Yes

[Menghini]

I am also having this same unexpected behavior. My use case is that I always have the bookmarks show only on the new tab page. Every now and then I want to drag a webpage to my bookmarks. When I do so, I hit "Ctrl + Shift + B" to show the bookmarks bar. When I am done dragging a webpage to the the bookmarks bar, I hit "Ctrl + Shift + B" again to hide it. However, this makes it so that the bookmarks setting is set to "never" instead of "Only on the new tab page" which is the expected behavior as it has been this way for many, many years.

[dgealow]

Same issue here, this is a huge regression for how I use the browser.

[dgealow]

I suspect this was introduced by brave/brave-core#15577 in response to #26072

[dgealow]

Ah yes, this behavior was explicitly noted in that ticket:

Note that on macOS with the View menu, the options Always show bookmarks is a checkbox. We will keep that checkbox to be Always and Never. Users will need to go into Settings to change to Only in the new tab page and. If users select Only in the new tab page in settings, the View menu will be reflected as Always.

So this was to some degree intentional; but a huge regression in usability for me. The state I want 95% of the time is that default "only show bookmarks in new tab" state (like Chrome does by default). However, sometimes I want / need to see bookmarks on a non-new-tab-page (e.g. to run my bookmarked "allow text selection" and "hide youtube end cards" javascriptlets), and enabling this with the keyboard shortcut now takes me into a state where getting back to the standard behavior is not possible with a keyboard shortcut and requires opening up the settings page. Seems like I'm not alone here.

[tbdx]

bump...

Came to raise the same issue after realising it was not a bug that would go away soon in a new release once it regressed.