Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using upstream url parser #333

Open
antonok-edm opened this issue Feb 12, 2024 · 0 comments
Open

Investigate using upstream url parser #333

antonok-edm opened this issue Feb 12, 2024 · 0 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@antonok-edm
Copy link
Collaborator

adblock-rust's URL parsing is an in-tree fork of some files from the rust-url project.

According to eed6eb0, it was done this way in order to slim down the full URL parser, likely for performance reasons. That being said, it's now a ~5 year old implementation that hasn't received any security updates or bugfixes.

If possible, I'd prefer to get this situation sorted out by using a well-audited upstream implementation, whether that is directly from rust-url or elsewhere.

@antonok-edm antonok-edm added the dependencies Pull requests that update a dependency file label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant