Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform linebreaks in note title - not in buttons #103

Open
budachst opened this issue Apr 13, 2018 · 5 comments
Open

Perform linebreaks in note title - not in buttons #103

budachst opened this issue Apr 13, 2018 · 5 comments

Comments

@budachst
Copy link

If a note titel becomes very long, it's not the title that gets wrapped, but instead the buttons get wrapped under one another. Either fade out the note title or perform a wrapping on that, but keep the buttons on one line.

grafik

@budachst
Copy link
Author

I am afraid that PR 108 doesn't resolve this issue. After pulling master, the buttons are still wrapped instead of the note title.

@trurli
Copy link
Collaborator

trurli commented Apr 15, 2018

Just to make sure, did you clean the browser cache?
If the issue persists, which browser are you using?

@budachst
Copy link
Author

Yes - I also checked with two different browsers (Safari/Firefox)

@trurli
Copy link
Collaborator

trurli commented Apr 15, 2018

You're right, it does not work out of the box when checking out a clean copy.

It is fixed (in theory), but I did not commit the file templates.js which is generated by html2js during the build. If you've got grunt, you can regenerate it yourself to make it work.

@brantje I'll make a new PR for that or is it unnecessary?

@brantje brantje reopened this Apr 15, 2018
@brantje
Copy link
Owner

brantje commented Apr 15, 2018

Did you run grunt?

trurli added a commit to trurli/nextnote that referenced this issue Apr 15, 2018
brantje added a commit that referenced this issue Apr 15, 2018
Commit generated templates.js to make changes for issue #103 visible w…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants