Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI fixes welcome? #63

Closed
dbaynard opened this issue Apr 24, 2023 · 4 comments · May be fixed by #68
Closed

CI fixes welcome? #63

dbaynard opened this issue Apr 24, 2023 · 4 comments · May be fixed by #68

Comments

@dbaynard
Copy link

redis-cell/.github/workflows/ci.yml

Lines 183 to 189 in bada85d

- name: "Get release info"
id: get_release_info
run: |
echo ::set-output name=file_name::${REPOSITORY_NAME##*/}-${TAG_REF_NAME##*/}-${{ matrix.target }}.tar.gz # RepositoryName-v1.0.0-arch.tar.gz
value=`cat release_url/release_url.txt`
echo ::set-output name=upload_url::$value

I noticed this library still uses ::set-output, which is deprecated. The fix (4 lines) shouls be straightforward.

-echo ::set-output name=file_name::${REPOSITORY_NAME##*/}-${TAG_REF_NAME##*/}-${{ matrix.target }}.tar.gz # RepositoryName-v1.0.0-arch.tar.gz
+echo "name=file_name::${REPOSITORY_NAME##*/}-${TAG_REF_NAME##*/}-${{ matrix.target }}.tar.gz" >> "$GITHUB_OUTPUT" # RepositoryName-v1.0.0-arch.tar.gz

I see CI is also throwing rust errors. I don't mind taking a look, if I'm to update the CI anyway. Would a PR be welcome?
@brandur
Copy link
Owner

brandur commented Jun 2, 2023

Hi @dbaynard, sorry about the really slow response on this one.

Yep, PRs welcome. I haven't taken a look at CI in a while, but I imagine it might need a bit of a modernization pass.

@dbaynard
Copy link
Author

dbaynard commented Jun 2, 2023

Ah I see you yourself fixed the breakages — it's just the warnings left, now.

I'll PR with the fixes (for deprecated ::set-output, as above, and updates to actions to fix the node.js issue). I'll add Keeping your actions up to date with Dependabot - GitHub Docs too — on a monthly schedule.

@dbaynard dbaynard mentioned this issue Jun 2, 2023
Open
5 tasks
@brandur
Copy link
Owner

brandur commented Jun 3, 2023

Excellent, thank you. And yeah, I pushed a few fixes this afternoon that repaired the most egregious problems.

@brandur
Copy link
Owner

brandur commented Jun 3, 2023

Going to close this in favor of #68 and related PRs.

@brandur brandur closed this as completed Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CI dbaynard/redis-cell
2 participants
@brandur @dbaynard