Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src_vault onsidered harmful #11

Open
chr-engwer opened this issue Sep 17, 2020 · 5 comments
Open

src_vault onsidered harmful #11

chr-engwer opened this issue Sep 17, 2020 · 5 comments

Comments

@chr-engwer
Copy link
Contributor

tar -xzf config/src_vault.tar.gz

You alternatively offer the option to unpack a tgz stored in the repo. I think this is dangerous, as it might easily diverge from the state of the repositories. I suggest to simply drop this option and remove the file from the repository.

@juangpc
Copy link
Contributor

juangpc commented Sep 17, 2020

It was a solution for when GitLab server was down. I think of it as a backup, a vault, that can't hurt.

@tmedani
Copy link
Member

tmedani commented Sep 17, 2020

yes, it was the case in the beginning of the project when GitLab was down.
maybe a solution is to check, time to time, the difference with the state of the repo, and update it from time to time with an auto script.

@juangpc
Copy link
Contributor

juangpc commented Sep 17, 2020

See 558ce41

@chr-engwer
Copy link
Contributor Author

I still consider this binary blob not good practice. First because you have to make sure that information can't diverge and second because storing binary data (and updating it over and over again) is not something git is made for.

@chr-engwer
Copy link
Contributor Author

.. But in the end you need to maintain it 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants