ShiftVector{S,D,T} type as a generic type, which KPoint{D,T} is an alias of
#206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #206 +/- ##
==========================================
+ Coverage 58.27% 58.76% +0.49%
==========================================
Files 22 23 +1
Lines 1493 1511 +18
==========================================
+ Hits 870 888 +18
Misses 623 623 ☔ View full report in Codecov by Sentry. |
brainandforce
force-pushed
the
features/shift-vector
branch
2 times, most recently
from
b186257
to
369c3de
Compare
brainandforce
force-pushed
the
features/shift-vector
branch
from
369c3de
to
2486cc9
Compare
brainandforce
force-pushed
the
features/shift-vector
branch
from
2486cc9
to
1d61d8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that it would probably be best to create a generic
ShiftVector{S,D,T}type that allows for the implementation ofKPoint{D,T}as a simple type alias. This would greatly simplify the reworked lattice data types that come later.