You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, KPoint{D} is a subtype of DenseVector{Float64}. In general, we should not be subtyping DenseArray at all, and because the implementation of KPoint{D} is a wrapper for a StaticArray{D,Float64} plus a Float64 shift parameter, we should define the following:
I have a better idea: a ShiftVector{D,R<:BySpace{D},T} <: StaticVector{D,T} type which can accomodate data shifts in either real or reciprocal space, and KPoint{D,T} aliases ShiftVector{D,ByReciprocalSpace{D},T}.
This should also dramatically simplify the new data grid implementation coming in 0.2.0.
Currently,
KPoint{D}
is a subtype ofDenseVector{Float64}
. In general, we should not be subtypingDenseArray
at all, and because the implementation ofKPoint{D}
is a wrapper for aStaticArray{D,Float64}
plus aFloat64
shift parameter, we should define the following:This would be a breaking change, as it would propagate to
KPointMesh{D}
,ReciprocalDataGrid{D}
, andPlanewaveWavefunction{D}
.The text was updated successfully, but these errors were encountered: