EnergyOccupancy data type and methods
#195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
==========================================
+ Coverage 59.17% 59.27% +0.09%
==========================================
Files 19 20 +1
Lines 1411 1429 +18
==========================================
+ Hits 835 847 +12
- Misses 576 582 +6
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should provide a unified way of working with pairs of energy and occupancy values, like those which exist in
PlanewaveWavefunction. Defined aremin_energy,max_energy,min_occupancy,max_occupancy,energy,occupancy,energies, andoccupancies, which work for anything which has anEnergiesOccupancies(alias forArray{EnergyOccupancy{T},N} where {T,N}constructor defined.