Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite GraphQLObjectMapper.getInputType to not copy output types. #18

Open
bpatters opened this issue May 26, 2017 · 0 comments
Open
Labels

Comments

@bpatters
Copy link
Owner

bpatters commented May 26, 2017

There are some limitations in the handling of input types because of the shortcut used in the GraphQLObjectMapper.getInputType copying the existing equivalent outputType. We need this functionality such that getInputType builds it's own full type hierarchy for the type, using caching, instead of trying to copy the outputType.

The primary problem is when the output type equivalent is a TypeReference that hasn't been resolved yet, making the copy fall through and reference the output type. Unfortunately this scenario isn't fixable without doing the above, because the output type hasn't been fully resolved yet and it's structure isn't known.

@bpatters bpatters added the 2.0.0 label May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant