Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a follow_all api to test that all links on a page go somewhere valid #46

Open
boydm opened this issue Nov 2, 2020 · 6 comments
Open
Assignees

Comments

@boydm
Copy link
Owner

boydm commented Nov 2, 2020

@marick I'm thinking of adding a new validation api to extract all links on a give page into a list, then scan the list to make sure each link goes somewhere valid. Essentially a scan for broken links. I think it would be useful for blog posts and such where some of the links may be hand-built in markdown.

Thoughts?

@boydm boydm self-assigned this Nov 2, 2020
@marick
Copy link
Contributor

marick commented Nov 9, 2020

Sorry for the delay. I don't have any opinion.

I do have a somewhat-related idea of parsing error messages out of a form and presenting them in a way people can easily check, so as to avoid grovelling through the HTML with regular expressions.

I also need to replace the custom assertions I added with the library I since released: https://github.com/marick/flow_assertions

I'm obsessively-focusing on a declarative library for testing (at first) form handling at the Ecto changeset level. Some dated documentation: https://marick.gitbook.io/idiosyncratic-elixir/declarative-testing-of-structured-form-input/preface

It'll be interesting to see if I can handle the common cases tersely and declaratively while still allowing weird cases to be handled in a traditional "do this, then this, then check this" style.

@boydm
Copy link
Owner Author

boydm commented Nov 9, 2020

No problem.

I like the work you've done on flow_assertions. Should integration take a dependency on it?

@marick
Copy link
Contributor

marick commented Nov 12, 2020

I plan to make a pull request for that dependency someday. I made some API changes so it's not an entirely trivial change.

@marick
Copy link
Contributor

marick commented Apr 25, 2021

I added a pull request on this a while back. Did you see it?

@boydm
Copy link
Owner Author

boydm commented Apr 25, 2021

Sorry. Didn't been totally swamped with Scenic, which is waaaaaay more work than I always expect.

@boydm
Copy link
Owner Author

boydm commented Sep 25, 2021

Hey @marick, I'm doing some maintenance on phoenix_integration. Is this one fixed?

Also, it's been fairly stable for quite a while. Thinking of calling it 1.0. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants