Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider rgbif::occ_data? #5

Closed
sckott opened this issue Aug 16, 2018 · 1 comment
Closed

Consider rgbif::occ_data? #5

sckott opened this issue Aug 16, 2018 · 1 comment
Assignees

Comments

@sckott
Copy link

sckott commented Aug 16, 2018

from JOSS review

I noticed that in get_benchmarking_data() you use rgbif::occ_search. You might consider rgbif::occ_data as it has all the same user interface (parameters) but only spends time internally getting and parsing the occurrence data and completely drops the other data that you don't want.

Also note that occ_search/occ_data use the GBIF occurrence API, which is limited to 200K results for any one query. So if you know or think you might need more than that you should use the download API via rgbif::occ_download and friends

also also note that we now have an interface to the GBIF maps API via rgbif::map_fetch which is a super fast way to get a raster map of occurrences, so you're not getting the actual occurrence data but a quick summary of the data- see https://www.gbif.org/developer/maps - Don't know if this is appropriate or not for your use case(s) but worth knowing about

@boyanangelov
Copy link
Owner

Hello @sckott, thanks for reviewing! I replaced the call to occ_search with occ_data. occ_download and map_fetch are nice. I think for this release the existing functions should do, but will keep those in mind for a future one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants