-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vignette #4
Comments
Hello @sckott. Thank you for submitting the issue! I did not manage to replicate the problem, but have added additional information about the Python and Java installations to both the I also updated the uploaded vignette to be in line with the version of the package, they will be in sync from now on. |
I'm having a different problem installing whilst building the vignette: devtools::install_github("boyanangelov/sdmbench", force = TRUE, build_vignettes = TRUE)
I have a working installation of maxent. E.g. I can do: library(dismo)
example(maxent) which completes successfully. Installing without vignettes, and then running the vignette as an R notebook, I get the following error in the chunk mentioned above:
traceback:
|
OK, looks like my error is actually due to an API change in ENMeval. On this line you access the
I would suggest you change the code and add ENMeval v0.3.0 as a version dependency. Alternatively, you could write code to handle whatever version of ENMeval is installed, but you'd have to be confident nothing else is different between the versions, and that could be tricky to maintain. I'm having some curious trouble trying to install an earlier version of ENMeval, so will wait for you to fix this before trying again. |
Thanks for going so deep to find the exact issue @goldingn . I adjusted the code to use the ENMEval v0.3.0 AUC extraction, and also added that as a dependency. Can you try to build the vignette again? |
Seems to work for me now, thanks! Not sure whether @sckott's issue was resolved though? |
Ok @goldingn. @sckott Can you check if the command
Then try to install keras separately from building the vignette (faster to debug): install.packages("keras")
library(keras)
install_keras() Let me know if any of those work and you can build the vignette, and I will add them to the README (already updated it with some stuff). |
yes will do |
works now, thanks |
from JOSS review:
I couldn't install while also building the vignette
I guess a python virtualenv problem, but not sure how to solve. Reason I bring up is that the vignette here https://boyanangelov.com/materials/sdmbench_vignette.html has examples that aren't in line with the version of the package at
v0.1.2
, e.g.,another example: had to change
benchmarking_data$raster_data$bioclim_data$bio1
tobenchmarking_data$raster_data$climate_variables$bio1
get the first plot eg to workThe text was updated successfully, but these errors were encountered: