Skip to content

Commit

Permalink
Prepare for 1.0.0 (Sorcery#157)
Browse files Browse the repository at this point in the history
* Remove jruby references

jruby was added previously, but never fully supported. Removing for now, pending
proper support.

* Match min ruby requirement with lowest tested ruby version

* Add maintainer to gemspec author list

* Update license to md format

* Remove excess whitespace

* Update rubocop ruby lock and regen TODO list

* Disable rubocop for migration files (breaks)

* Fix Bundler/OrderedGems

* Fix rails 6 deprecation warning

* Add missing newline

* Fix Gemspec/OrderedDependencies

* Fix Gemspec/RequiredRubyVersion and regen TODO

* Fix Layout/AlignHash

* Fix Layout/ClosingParenthesisIndentation

* Fix Layout/EmptyLineAfterGuardClause

* Fix Layout/EmptyLineBetweenDefs

* Fix Layout/EmptyLines

Fixed by last commit

* Fix Layout/EmptyLinesAroundArguments

* Fix Layout/EmptyLinesAroundBlockBody

* Fix Layout/EmptyLinesAroundClassBody

* Fixed Layout/EmptyLinesAroundModuleBody on previous commit

* Fix Layout/EndAlignment

* Fix Layout/ExtraSpacing

* Fix Layout/FirstParameterIndentation

* Fix Layout/IndentHash

* Fix Layout/MultilineMethodCallBraceLayout

* Fix Layout/MultilineMethodCallIndentation

* Fix Layout/MultilineOperationIndentation

* Fix Layout/SpaceAfterComma

* Fix Layout/SpaceAroundEqualsInParameterDefault

* Fix Layout/SpaceAroundOperators

* Fix Layout/SpaceBeforeBlockBraces

* Fix Layout/SpaceInsideBlockBraces

* Fix Layout/SpaceInsideHashLiteralBraces

* Fix Layout/TrailingBlankLines

* Fix Layout/TrailingWhitespace

* Fix Lint/AmbiguousBlockAssociation

* Fix Lint/AssignmentInCondition

* Fix Lint/DuplicateMethods

* Add rubocop to development dependencies

* Rails 4.1 has been released, remove rescue statement

* Fix Lint/HandleExceptions

* Fix Lint/NonLocalExitFromIterator

* Fix Lint/ParenthesesAsGroupedExpression

* Fix Lint/UnderscorePrefixedVariableName

* Fix Lint/UselessAssignment

* Fix Lint/Void - Found potentially broken specs for remember_me functionality

* Fix Naming/FileName

* Fix Style/AndOr

* Fix Style/BracesAroundHashParameters

* Add Github issue template

* Fix Style/TrailingCommaInHashLiteral

* Fix Style/TrailingCommaInArguments

* Fix Style/SymbolArray

* Fix Style/StringLiterals

* Fix Style/RescueStandardError

* Fix Style/RegexpLiteral

* Fix Style/RedundantSelf

* Fix Style/RedundantReturn

* Fix Style/RedundantParentheses

* Move harder to solve rubocop issues to prepare for 1.0.0

* Naming conventions will be fixed by rewrite in 1.0.0

* Fix Naming/MemoizedInstanceVariableName

* Naming conventions will be fixed by rewrite in 1.0.0

* Fix Style/PercentLiteralDelimiters

* Fix Style/ParenthesesAroundCondition

Fixed by previous commit

* Fix Style/NumericLiterals

* Fix Style/MutableConstant

* Fix Style/MultipleComparison

* Fix Style/IfUnlessModifier

Fixed on previous commit

* Fix Style/HashSyntax

* Fix Style/GuardClause

* Fix Style/FormatString

* Fix Style/ExpandPathArguments

* Fix Style/EvalWithLocation

* Fix Style/EmptyLiteral

* Disable Style/DoubleNegation

* Documentation will be fixed by rewrite in 1.0.0

* Fix Style/Dir

* Fix Style/ConditionalAssignment

Fixed by previous commit

* Fix Style/ClassAndModuleChildren

* Regenerate rubocop TODO

* Add maintainer to gemspec email list
  • Loading branch information
joshbuker authored Nov 8, 2018
1 parent e3045a9 commit 6c155be
Show file tree
Hide file tree
Showing 58 changed files with 658 additions and 926 deletions.
20 changes: 20 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
Please complete all sections.

### Configuration

- Sorcery Version: ``
- Ruby Version: ``
- Framework: ``
- Platform: ``

### Expected Behavior

Tell us what should happen.

### Actual Behavior

Tell us what happens instead.

### Steps to Reproduce

Please list all steps to reproduce the issue.
54 changes: 52 additions & 2 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,55 @@
# Use auto generated file to ignore existing warnings.
inherit_from: '.rubocop_todo.yml'
inherit_from: .rubocop_todo.yml

AllCops:
Exclude:
- 'lib/generators/sorcery/templates/**/*'
TargetRubyVersion: 2.2

# See: https://github.com/rubocop-hq/rubocop/issues/3344
Style/DoubleNegation:
Enabled: false

####################
## Pre-1.0.0 Code ##
####################

Metrics/AbcSize:
Exclude:
- 'lib/**/*'
- 'spec/**/*'
Metrics/BlockLength:
Exclude:
- 'lib/**/*'
- 'spec/**/*'
Metrics/LineLength:
Exclude:
- 'lib/**/*'
- 'spec/**/*'
Metrics/ClassLength:
Exclude:
- 'lib/**/*'
- 'spec/**/*'
Metrics/CyclomaticComplexity:
Exclude:
- 'lib/**/*'
- 'spec/**/*'
Metrics/MethodLength:
Exclude:
- 'lib/**/*'
- 'spec/**/*'
Metrics/PerceivedComplexity:
Exclude:
- 'lib/**/*'
- 'spec/**/*'
Naming/AccessorMethodName:
Exclude:
- 'lib/**/*'
- 'spec/**/*'
Naming/PredicateName:
Exclude:
- 'lib/**/*'
- 'spec/**/*'
Style/Documentation:
Exclude:
- 'lib/**/*'
- 'spec/**/*'
Loading

0 comments on commit 6c155be

Please sign in to comment.