Skip to content

Commit 6c155be

Browse files
authored
Prepare for 1.0.0 (Sorcery#157)
* Remove jruby references jruby was added previously, but never fully supported. Removing for now, pending proper support. * Match min ruby requirement with lowest tested ruby version * Add maintainer to gemspec author list * Update license to md format * Remove excess whitespace * Update rubocop ruby lock and regen TODO list * Disable rubocop for migration files (breaks) * Fix Bundler/OrderedGems * Fix rails 6 deprecation warning * Add missing newline * Fix Gemspec/OrderedDependencies * Fix Gemspec/RequiredRubyVersion and regen TODO * Fix Layout/AlignHash * Fix Layout/ClosingParenthesisIndentation * Fix Layout/EmptyLineAfterGuardClause * Fix Layout/EmptyLineBetweenDefs * Fix Layout/EmptyLines Fixed by last commit * Fix Layout/EmptyLinesAroundArguments * Fix Layout/EmptyLinesAroundBlockBody * Fix Layout/EmptyLinesAroundClassBody * Fixed Layout/EmptyLinesAroundModuleBody on previous commit * Fix Layout/EndAlignment * Fix Layout/ExtraSpacing * Fix Layout/FirstParameterIndentation * Fix Layout/IndentHash * Fix Layout/MultilineMethodCallBraceLayout * Fix Layout/MultilineMethodCallIndentation * Fix Layout/MultilineOperationIndentation * Fix Layout/SpaceAfterComma * Fix Layout/SpaceAroundEqualsInParameterDefault * Fix Layout/SpaceAroundOperators * Fix Layout/SpaceBeforeBlockBraces * Fix Layout/SpaceInsideBlockBraces * Fix Layout/SpaceInsideHashLiteralBraces * Fix Layout/TrailingBlankLines * Fix Layout/TrailingWhitespace * Fix Lint/AmbiguousBlockAssociation * Fix Lint/AssignmentInCondition * Fix Lint/DuplicateMethods * Add rubocop to development dependencies * Rails 4.1 has been released, remove rescue statement * Fix Lint/HandleExceptions * Fix Lint/NonLocalExitFromIterator * Fix Lint/ParenthesesAsGroupedExpression * Fix Lint/UnderscorePrefixedVariableName * Fix Lint/UselessAssignment * Fix Lint/Void - Found potentially broken specs for remember_me functionality * Fix Naming/FileName * Fix Style/AndOr * Fix Style/BracesAroundHashParameters * Add Github issue template * Fix Style/TrailingCommaInHashLiteral * Fix Style/TrailingCommaInArguments * Fix Style/SymbolArray * Fix Style/StringLiterals * Fix Style/RescueStandardError * Fix Style/RegexpLiteral * Fix Style/RedundantSelf * Fix Style/RedundantReturn * Fix Style/RedundantParentheses * Move harder to solve rubocop issues to prepare for 1.0.0 * Naming conventions will be fixed by rewrite in 1.0.0 * Fix Naming/MemoizedInstanceVariableName * Naming conventions will be fixed by rewrite in 1.0.0 * Fix Style/PercentLiteralDelimiters * Fix Style/ParenthesesAroundCondition Fixed by previous commit * Fix Style/NumericLiterals * Fix Style/MutableConstant * Fix Style/MultipleComparison * Fix Style/IfUnlessModifier Fixed on previous commit * Fix Style/HashSyntax * Fix Style/GuardClause * Fix Style/FormatString * Fix Style/ExpandPathArguments * Fix Style/EvalWithLocation * Fix Style/EmptyLiteral * Disable Style/DoubleNegation * Documentation will be fixed by rewrite in 1.0.0 * Fix Style/Dir * Fix Style/ConditionalAssignment Fixed by previous commit * Fix Style/ClassAndModuleChildren * Regenerate rubocop TODO * Add maintainer to gemspec email list
1 parent e3045a9 commit 6c155be

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+658
-926
lines changed

.github/ISSUE_TEMPLATE.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
Please complete all sections.
2+
3+
### Configuration
4+
5+
- Sorcery Version: ``
6+
- Ruby Version: ``
7+
- Framework: ``
8+
- Platform: ``
9+
10+
### Expected Behavior
11+
12+
Tell us what should happen.
13+
14+
### Actual Behavior
15+
16+
Tell us what happens instead.
17+
18+
### Steps to Reproduce
19+
20+
Please list all steps to reproduce the issue.

.rubocop.yml

Lines changed: 52 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,55 @@
1-
# Use auto generated file to ignore existing warnings.
2-
inherit_from: '.rubocop_todo.yml'
1+
inherit_from: .rubocop_todo.yml
32

43
AllCops:
4+
Exclude:
5+
- 'lib/generators/sorcery/templates/**/*'
56
TargetRubyVersion: 2.2
7+
8+
# See: https://github.com/rubocop-hq/rubocop/issues/3344
9+
Style/DoubleNegation:
10+
Enabled: false
11+
12+
####################
13+
## Pre-1.0.0 Code ##
14+
####################
15+
16+
Metrics/AbcSize:
17+
Exclude:
18+
- 'lib/**/*'
19+
- 'spec/**/*'
20+
Metrics/BlockLength:
21+
Exclude:
22+
- 'lib/**/*'
23+
- 'spec/**/*'
24+
Metrics/LineLength:
25+
Exclude:
26+
- 'lib/**/*'
27+
- 'spec/**/*'
28+
Metrics/ClassLength:
29+
Exclude:
30+
- 'lib/**/*'
31+
- 'spec/**/*'
32+
Metrics/CyclomaticComplexity:
33+
Exclude:
34+
- 'lib/**/*'
35+
- 'spec/**/*'
36+
Metrics/MethodLength:
37+
Exclude:
38+
- 'lib/**/*'
39+
- 'spec/**/*'
40+
Metrics/PerceivedComplexity:
41+
Exclude:
42+
- 'lib/**/*'
43+
- 'spec/**/*'
44+
Naming/AccessorMethodName:
45+
Exclude:
46+
- 'lib/**/*'
47+
- 'spec/**/*'
48+
Naming/PredicateName:
49+
Exclude:
50+
- 'lib/**/*'
51+
- 'spec/**/*'
52+
Style/Documentation:
53+
Exclude:
54+
- 'lib/**/*'
55+
- 'spec/**/*'

0 commit comments

Comments
 (0)