Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]:added dark-light toggle them in admin #1777

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jatingodnani
Copy link

@jatingodnani jatingodnani commented Oct 13, 2023

What does this PR do?

added function which give the user to change the theme of admin-portal
Fixes #1240

@ghost
Copy link

ghost commented Oct 13, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@jatingodnani
Copy link
Author

jatingodnani commented Oct 14, 2023

@deepakprabhakara check my pr

@jatingodnani
Copy link
Author

@NathanTarbert check pr

@NathanTarbert
Copy link
Contributor

@niwsa | @devkiran

@devkiran
Copy link
Contributor

@jatingodnani Thanks for your PR. I did a quick test, the dark theme UI doesn't look nice overall. I think we need to do a bit more work to get this working properly. This may requires going through each component and make sure the color is correct for both dark and light theme. Overall this would take a bit more work than I expected.

@jatingodnani
Copy link
Author

@devkiran i can do that you can tell me which part is not hoing well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode support for Admin Portal
4 participants