Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated containerd.WithSchema1Conversion from host-ctr #64

Open
jpculp opened this issue Aug 1, 2024 · 0 comments
Open

Remove deprecated containerd.WithSchema1Conversion from host-ctr #64

jpculp opened this issue Aug 1, 2024 · 0 comments

Comments

@jpculp
Copy link
Member

jpculp commented Aug 1, 2024

WithSchema1Conversion is used to convert Docker registry schema 1 manifests to oci manifests on pull. Without this option schema 1 manifests will return a not supported error. This is no deprecated and it is recommended to use schema 2 or OCI images.

Platform I'm building on:

N/A

What I expected to happen:

host-ctr to pass lints

What actually happened:

cmd/host-ctr/main.go:1053:4: SA1019: containerd.WithSchema1Conversion is deprecated: use Schema 2 or OCI images. (staticcheck)
			containerd.WithSchema1Conversion,

How to reproduce the problem:

Remove the exception added to host-ctr/main.go and run golangci-lint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant