Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite usages of compiler-synthesized Differentiable.zeroTangentVector #261

Open
dan-zheng opened this issue Jan 11, 2021 · 4 comments
Open
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dan-zheng
Copy link
Collaborator

Protocol requirement Differentiable.zeroTangentVectorInitializer and computed property Differentiable.zeroTangentVector are being removed in swiftlang/swift#35329 as a simplification.

"Per-instance zeros" are no longer a concept, there is only the "static universal zero" TangentVector.zero for all tangent vector types.

There are some updates of Differentiable.zeroTangentVector in SwiftFusion. This issue tracks updating those occurrences to use something else (manual implementation of <type>.zeroTangentVector via directly calling Tensor(zeros:on:), etc.

@dan-zheng dan-zheng added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 11, 2021
@dan-zheng
Copy link
Collaborator Author

Does anyone (especially Georgia Tech Students like @acoadmarmon) have time to look into this?

That would be a huge help! Help from you on issues like this would also be great empirical evidence that SwiftFusion can scale!

@dan-zheng
Copy link
Collaborator Author

Unless folks (like @acoadmarmon) have time to look into this issue today, I will look into it! It unblocks swiftlang/swift#35329.

I'm happy to do work like this from time to time, but I wouldn't want to be the only "line of defense" as I'm not strictly a SwiftFusion code owner. It would be nice to discuss some process for prioritizing and distributing issues like this in the future!

@acoadmarmon
Copy link
Collaborator

Hey Dan! This is on my to do list for tomorrow if it can wait until then.

@dan-zheng
Copy link
Collaborator Author

That would be splendid! Thanks bunches Andrew :) make MLKJ proud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants