From 9f1f75c30a6d9fb3439577ad272d64492f2d16b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erin=E2=80=84Yuki=E2=80=89Schlarb?= Date: Mon, 12 Feb 2024 22:03:52 +0000 Subject: [PATCH] Prevent exception while running BorgVersionJob with unexpected lines on stderr MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The borg job logic expects the `profile_name` key to be unconditionally present in the params if any data is received on stderr. This causes the BorgVersionJob (which didn’t set this param) to fail if any unexpected output – such as LD_PRELOAD warnings – in generated while running `borg --version`. This in turn causes Vorta to silently (other than an unrelated looking exception in the console output) fall back to assuming borg 1.1.0 as the borg version. --- src/vorta/borg/version.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vorta/borg/version.py b/src/vorta/borg/version.py index 348aaa71c..e353b1a11 100644 --- a/src/vorta/borg/version.py +++ b/src/vorta/borg/version.py @@ -22,6 +22,7 @@ def prepare(cls): return ret ret['cmd'] = ['borg', '--version'] + ret['profile_name'] = 'default' ret['ok'] = True return ret