Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise borgstore specific exceptions for expected errors #34

Closed
ThomasWaldmann opened this issue Sep 11, 2024 · 0 comments
Closed

raise borgstore specific exceptions for expected errors #34

ThomasWaldmann opened this issue Sep 11, 2024 · 0 comments
Assignees
@ThomasWaldmann
Milestone
0.0.3

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Sep 11, 2024 •
edited
Loading

E.g. if a url can't be parsed, it's currently a ValueError:

ValueError: Invalid Backend Storage URL: sftp://gateway/tmp/test

If it would be a more specific exception, borgbackup (or other code using borgstore) could catch these and not show a traceback.

See also borgbackup/borg#8373 .
@ThomasWaldmann ThomasWaldmann added this to the 0.0.3 milestone Sep 11, 2024
@ThomasWaldmann ThomasWaldmann self-assigned this Sep 11, 2024
ThomasWaldmann added a commit that referenced this issue Sep 11, 2024
@ThomasWaldmann
Merge pull request #35 from ThomasWaldmann/exceptions
80e526b 
store: raise BE specific exception, fixes #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasWaldmann ThomasWaldmann

Labels
None yet
Projects
None yet
Milestone
0.0.3
Development

No branches or pull requests
1 participant
@ThomasWaldmann