Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the username is passed from Wordpress to Etherpad #22

Open
JohnMcLear opened this issue Nov 22, 2012 · 3 comments
Open

Make sure the username is passed from Wordpress to Etherpad #22

JohnMcLear opened this issue Nov 22, 2012 · 3 comments

Comments

@JohnMcLear
Copy link

Etherpad supports ?userName IE http://beta.etherpad.org/p/foo?userName=test

@boonebgorges
Copy link
Owner

I'm doing it at the time of Etherpad user creation: https://github.com/boonebgorges/participad/blob/master/includes/class-participad-user.php#L92 Is that enough?

@JohnMcLear
Copy link
Author

Hrm it seems like enough but I wasn't sure if it worked or not.. Guess this needs testing and confirming. Leave it open and if you can create a Label called "Waiting for testing" that we can pass off as low hanging fruit

@boonebgorges
Copy link
Owner

Yeah. It probably isn't a bad idea to do it on every pad load anyway, because I'm passing WP's display_name, which is a text field that users can change, so it may not be persistent between sessions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants