Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writer should not receive email notification #50

Closed
jezza16 opened this issue Oct 22, 2013 · 4 comments
Closed

Writer should not receive email notification #50

jezza16 opened this issue Oct 22, 2013 · 4 comments

Comments

@jezza16
Copy link

jezza16 commented Oct 22, 2013

Hi,
The plugin is really great. But would it be possible to modify code so as not to send a notification email to the writer of a news.
thanks

@dwenaus
Copy link
Collaborator

dwenaus commented Feb 2, 2014

This will be fixed in version 3.4.1 out very soon.

@ray Should I push version 3.4.1 to the WP plugin repository with all the other helpful changes you've made since the 3.4 release?

@dwenaus dwenaus closed this as completed Feb 2, 2014
@r-a-y
Copy link
Collaborator

r-a-y commented Feb 3, 2014

@dwenaus - The only change I've made since 3.4 is commit a0a156e.

It'd be nice to fix #48 as well for 3.4.1.

@yannbug
Copy link

yannbug commented Feb 3, 2014

Yes please, don't forget #48 ! You have a proposed fix, so if you have no time to work it out any other way, just include the fix as is :) - don't want to have to repatch the new version. Thanks.

@dwenaus
Copy link
Collaborator

dwenaus commented Feb 4, 2014

@r-a-y actually, I did a diff and it looks like the changes you made on August 22nd have not been pushed either. But they all look logical and good to me. So I'm guessing it's safe.

@yannbug regarding #48 there seems to be some consensus on the direction to take, but the code has not been updated to reflect that I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants