German Email Translation Problem

[christianlersch]

At the moment I am working on a translation problem in the german email.

I see that in the PO German Translation everything is correct translated. Also in the file 'bp-activity-subscription-functions.php' everything is correct with the sprintf Function...

I also copied the buddypress-group-email-subscription-de_DE.mo + po files to the wp-content/languages/plugins folder but this did not work.

I see that in Buddypress you need to "install" the Mails under Tools / Buddypress / Delete and reinstall Emails. But this also not Worked.

Under Emails (/wp-admin/edit.php?post_type=bp-email) I find some Mails ([{{{site.name}}}] {{{ges.subject}}}) that coming from you but not the Email in the Screenshot...

Earlier we use the "de_DE_formal" Language and I thought that the Problem comes from not completed Language Files because the Formal is not used so often. Now we switch to the normal de_DE language to get better and more translations. But it sesm not to work better...

Do you have an idea for me what I can do to check where is the Problem?

[boonebgorges]

It looks like the de_DE localization that ships with the plugin has some errors in it.

For example, the string "Your email setting for this group is" is represented in de_DE like this: https://github.com/boonebgorges/buddypress-group-email-subscription/blob/1063628f719619cf387eaf8015705d4eaab2b17d/languages/buddypress-group-email-subscription-de_DE.po#L633C5-L633C5 This says that the original string is Your email setting for this group is: . But the actual string in the codebase has a placeholder Your email setting for this group is: %s

buddypress-group-email-subscription/bp-activity-subscription-functions.php

Line 766 in 1063628

$email_setting_string = __( 'Your email setting for this group is: %s', 'buddypress-group-email-subscription' );

Something similar is probably happening in the case of the other untranslated string.

It's likely that the translations were correct when they were first contributed, but that the code has since changed in ways that made the translations not match.

So I think the path forward is to update the translations. This could happen by someone downloading the latest .pot file https://github.com/boonebgorges/buddypress-group-email-subscription/blob/4.2.x/languages/buddypress-group-email-subscription.pot and translating using Poedit or something similar, then sending a pull request. Or you could translate at https://translate.wordpress.org/locale/de/default/wp-plugins/buddypress-group-email-subscription/, and we could stop shipping the translation with the plugin, inheriting it instead from wordpress.org.

[christianlersch]

I would like to help with the german translation and would to it over Github if you like. :)

[christianlersch]

Is this ok for you? Shout I commit the german translation?

[boonebgorges]

@christianlersch Yes, please feel free to submit corrections. Vielen Dank!