Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to override default digest markup #120

Open
boonebgorges opened this issue Nov 13, 2017 · 1 comment
Open

Allow plugins to override default digest markup #120

boonebgorges opened this issue Nov 13, 2017 · 1 comment

Comments

@boonebgorges
Copy link
Owner

It's not currently possible to override the basic logic that BPGES uses to build digest HTML. There are no filters, except on single pieces of markup, and the way ass_digest_fire() is constructed mixes together business and display logic.

This should be improved, so that the function basically has three parts (which may be broken into separate functions):

  1. The digest queue is pulled up and sorted
  2. For each user who is to receive a digest, the HTML is built from the raw list of groups/activity_ids.
  3. BPGES uses the HTML to send the digests

The function should be rewritten so that 2 can easily be done elsewhere.

@boonebgorges
Copy link
Owner Author

A note that the existing ass_digest_format_item_group and ass_digest_format_item filters can be leveraged for some of this work. But ass_digest_format_item_group doesn't receive enough information to be properly modified - it needs at least a list of activity ids.

boonebgorges added a commit that referenced this issue Nov 17, 2017
This makes it easier to customize the group's digest markup.

See #120.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant