Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error consolidating UK data #41

Closed
aramse opened this issue Apr 29, 2020 · 7 comments
Closed

Error consolidating UK data #41

aramse opened this issue Apr 29, 2020 · 7 comments

Comments

@aramse
Copy link
Contributor

aramse commented Apr 29, 2020

Running the consolidate_uk.py file is returning the following error:

$ ./bin/consolidate_uk.py > data/uk.csv
Traceback (most recent call last):
  File "./bin/consolidate_uk.py", line 55, in <module>
    print(",".join([d, b, str(countries[b]["confirmed"][i]), str(countries[b]["deceased"][i])]))
IndexError: list index out of range
@RouxRC RouxRC closed this as completed in 7f49cfc Apr 29, 2020
@boogheta
Copy link
Owner

Well caught, this was due to some change in England's historical data that was improved by @tomwhite and badly handled on my side.
Thanks for the report!

@aramse
Copy link
Contributor Author

aramse commented May 1, 2020

@boogheta I'm seeing the same error again.

$ bin/update_sources.sh 
Traceback (most recent call last):
  File "./bin/consolidate_uk.py", line 58, in <module>
    print(",".join([d, b, str(countries[b]["confirmed"][i]), str(countries[b]["deceased"][i])]))
IndexError: list index out of range

But it seems it fails this time near the very end of processing the data, and doesn't affect any data that actually gets charted.

@boogheta
Copy link
Owner

boogheta commented May 4, 2020

Yes indeed, thanks again @aramse.
The data was improved again, now tests are complete and I could integrate them as well, although it looks to me like there are some weird values for England and UK total at the source, I took an arbitrary choice in the mean time and reported it here tomwhite/covid-19-uk-data#52

@aramse
Copy link
Contributor Author

aramse commented Jun 10, 2020

@boogheta firstly want to thank you for maintaining this beautifully efficient graph for comparing COVID data across countries. It's been very helpful to me personally in keeping up more with just the numbers and less with the politics.

Also wanted to mention that I'm actually running this on Google Cloud: see this link.

This is equipped with automatic data refreshes, autoscaling, CI/CD, monitoring, and more. Let me know if you're interested in a detailed demo of how this is set up and/or you're interested in doing this for any other applications!

(Also let me know if I should make any changes with the way I'm crediting yourself/your company in the banner of this page.)

@boogheta
Copy link
Owner

boogheta commented Jun 11, 2020

Hi @aramse,
I don't have any issue with the app being replicated slighly modified, this is open source.
Although, it does have a specific open source licence (AGPL v3) which supposes to respect a few rules when you do so. Among which it minimally requires you to:

  • attribute properly (so a link to the médialab website won't suffice, you need to give links to the original app and its code, with the original name of the app and of the authors, meaning me from médialab and not only médialab)
  • redistribute the sourcecode of any public instance released, meaning the code of your fork shall be also released as opensource under that same licence on some public git repository and linked to from your platform

Thanks in advance!

@aramse
Copy link
Contributor Author

aramse commented Jun 11, 2020

Great will look to do make the needed modifications to comply here, thank you!

@aramse
Copy link
Contributor Author

aramse commented Jun 13, 2020

Updated to better comply 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants