From 66cad6d38a068371fe5d59bdb690ac22f576b550 Mon Sep 17 00:00:00 2001 From: Emmanuel Duchastenier Date: Fri, 16 Feb 2024 10:55:42 +0100 Subject: [PATCH 1/2] chore(inputs): set inputs as boolean as it is easier to handle through check boxes --- .github/workflows/propagate-doc-upwards.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/propagate-doc-upwards.yml b/.github/workflows/propagate-doc-upwards.yml index 27d548bed..c39685ea0 100644 --- a/.github/workflows/propagate-doc-upwards.yml +++ b/.github/workflows/propagate-doc-upwards.yml @@ -5,13 +5,13 @@ on: workflow_dispatch: inputs: dry-run: - description: 'If true, run the merge locally but do not push to remote' - required: false - default: 'false' + type: boolean + description: 'Dry run: if checked, run the merge locally but do not push to remote' + default: false slack-notifications: - description: 'If true, send slack notifications when errors occur' - required: false - default: 'false' + type: boolean + description: 'If checked, send slack notifications when errors occur' + default: true jobs: propagate-doc-upwards: @@ -55,7 +55,7 @@ jobs: ./.././bonita-documentation-site/scripts/propagate_doc_upwards.bash - name: Send message to Slack channel - if: failure() && (github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && github.event.inputs.slack-notifications == 'true') ) + if: failure() && (github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && github.event.inputs.slack-notifications) ) uses: bonitasoft/actions/packages/notify-slack@v2 with: CHANNEL_ID: ${{ vars.SLACK_CHANNEL_ID }} From 6f557c31b42c7faefd9f025156bcd3e6c4913021 Mon Sep 17 00:00:00 2001 From: Emmanuel Duchastenier Date: Fri, 1 Mar 2024 14:56:18 +0100 Subject: [PATCH 2/2] Integrate code review feedbacks --- .github/workflows/propagate-doc-upwards.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/propagate-doc-upwards.yml b/.github/workflows/propagate-doc-upwards.yml index c39685ea0..5e1aae0b6 100644 --- a/.github/workflows/propagate-doc-upwards.yml +++ b/.github/workflows/propagate-doc-upwards.yml @@ -11,7 +11,7 @@ on: slack-notifications: type: boolean description: 'If checked, send slack notifications when errors occur' - default: true + default: false jobs: propagate-doc-upwards: @@ -55,7 +55,7 @@ jobs: ./.././bonita-documentation-site/scripts/propagate_doc_upwards.bash - name: Send message to Slack channel - if: failure() && (github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && github.event.inputs.slack-notifications) ) + if: failure() && (github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && github.event.inputs.slack-notifications == 'true') ) uses: bonitasoft/actions/packages/notify-slack@v2 with: CHANNEL_ID: ${{ vars.SLACK_CHANNEL_ID }}