The Vale syntax checker should not set the PR in error

[jeromecambon]

Currently, the Vale syntax checker we have enabled on the bonita-doc repository set the PR in error as soon as a Vale warning appears.
See this PR for instance.

[jeromecambon]

This is related to an issue in the Vale action that makes the workflow to fail.
This is also not possible to set the reviewdog 'level' parameter, that would allow to set the error level.
Moreover, it seems it is not possible to force a workflow to have an exit code different of 'failure' (see https://docs.github.com/en/actions/creating-actions/setting-exit-codes-for-actions)

[tbouffard]

Moreover, it seems it is not possible to force a workflow to have an exit code different of 'failure' (see docs.github.com/en/actions/creating-actions/setting-exit-codes-for-actions)

This link is about setting an action exit code, not the workflow exit code. What we would like is to set the workflow global status to neutral or something similar. This may not possible for now as well.
See also https://docs.github.com/en/rest/checks/runs#create-a-check-run

[tbouffard]

ℹ️ Vale is disable in bonita-doc until we found a solution: bonitasoft/bonita-doc#2218

[jeromecambon]

Still an issue that make reviewdo to fail, when we have big files with many errors/warnings:

Error: reviewdog: Too many results (annotations) in diff.
  You may miss some annotations due to GitHub limitation for annotation created by logging command.
  Please check GitHub Actions log console to see all results.
  
  Limitation:
  - 10 warning annotations and 10 error annotations per step
  - 50 annotations per job (sum of annotations from all the steps)
  - 50 annotations per run (separate from the job annotations, these annotations aren't created by users)

[jeromecambon]

Created an issue for Vale about this:
errata-ai/vale-action#89

[jeromecambon]

I made a fix in the Vale action, and wanted to create a PR, but don't have (yet) the rights to do it.

[tbouffard]

@jeromecambon to create the PR, you must first fork the vale-action repository, push your changes to this fork and then you will be able to create a PR targeting the vale-action repo from your fork.
See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks

[jeromecambon]

The issue errata-ai/vale-action#84 is not fixed for a while, so we can close this issue, since Vale has been disabled.
We are going to remove the configuration from the bonita-doc repository: bonitasoft/bonita-doc#2389
This is the sole repository that includes Vale configuration (see #499).

[jeromecambon]

Setting the right close reason.