Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review tests for Lucene.Net assembly #117

Open
bongohrtech opened this issue Oct 11, 2019 · 0 comments
Open

Review tests for Lucene.Net assembly #117

bongohrtech opened this issue Oct 11, 2019 · 0 comments

Comments

@bongohrtech
Copy link
Owner

A line-by-line review would be best, but at the very least we should be checking that the implementations are complete and the test conditions are the same as in Java Lucene 4.8.0. Checking at the method level to ensure they all exist and have the right attributes has been completed already on Lucene.Net (core).

Occasionally, tests are still being found with important lines that have been commented because the functionality didn't exist at the time they were ported. We need some assurance that none of our green tests are false positives.

The tests that are most likely to have issues are the tests for

  1. Lucene.Net (core)
  2. Lucene.Net.Classification
  3. Lucene.Net.Codecs
  4. Lucene.Net.Expressions
  5. Lucene.Net.Facet
  6. Lucene.Net.Join
  7. Lucene.Net.Queries

JIRA link - [LUCENENET-632] created by nightowl888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant