Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New age groups (40+) #494

Open
dreamhatx opened this issue Jun 7, 2021 · 6 comments
Open

New age groups (40+) #494

dreamhatx opened this issue Jun 7, 2021 · 6 comments

Comments

@dreamhatx
Copy link

The filter_centers_by_age function in utils.py, the centers are classified with 2 age limits (18 and 45). But, now there are sessions with age limits 40 (maybe others also).

So, a person with >40 age will not be able to book the vaccine in those sessions.

dreamhatx added a commit to dreamhatx/covid-vaccine-booking that referenced this issue Jun 7, 2021
- fixes bombardier-gif#494
- Will make the minimum age filter continuous instead of discrete steps
dreamhatx added a commit to dreamhatx/covid-vaccine-booking that referenced this issue Jun 7, 2021
- fixes bombardier-gif#494
- Will make the minimum age filter continuous instead of discrete steps
dreamhatx added a commit to dreamhatx/covid-vaccine-booking that referenced this issue Jun 7, 2021
Fixes bombardier-gif#494
- Will make the minimum age filter continuous instead of discrete steps
@karanssh
Copy link

karanssh commented Jun 8, 2021

Just adding here, some states have other random age groups too : source: https://twitter.com/BloreVaccine/status/1401059091485585408

Making this little more generic would help, I think

@dreamhatx
Copy link
Author

Yes, in the PR #495, I have changed from checking based on predefined age categories to just checking if the age of beneficiary is greate than center minimum age.

@dreamhatx
Copy link
Author

As @Nakul93 has pointed out (here) there is an error for booking a session with min_age_booking 18 for an individual with age 45. I have not been able to test this personally.

So, I think this fix (#495) would not be valid or any fix will be hard to implement as @karanssh pointed that (here), there are numerous age classes and it might be impossible to filter based all the age classes and is very hard to know how the different age classes is affected by the limits and errors. (like can a person with age 42 for booking in an 18+ session or only for a 40+ session)

But I still don't get the logic where 18+ session is not bookable by a person with age above 45. Hoping for a fix soon as there are a lot of 40+ centers in my area.

@6mxo89sqh
Copy link
Collaborator

@Nakul93 any conclusion here? Do we need to handle it or is not required?

@Nakul93
Copy link
Collaborator

Nakul93 commented Jun 8, 2021

I suggest we keep this open for now. We might need to handle it in the future.
As of now there are very few states and centers that are using these varying age filters.

@mrms123
Copy link

mrms123 commented Jun 8, 2021

Also, with the changed vaccination policy (free for all above 18) - we might see these categories going away in the near future

Do we have a wiki made - if we do, maybe we could leave a small note there on how to edit the age category in the code.
Actually - could refactor the code to make all of those constants (URLs, age limits, vaccine choices - as a separate constants file) - making it easier for someone to tweak them if need be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants