Exception Aws::DynamoDB::Errors::ResourceInUseException: Attempt to change a resource which is still in use: Table is being created: terraform_locks

[alexjfisher]

Hi!

I think there is a race condition during terraspace all up if batch 1 contains more than 1 stack and the environment has never been used before so doesn't contain a terraform_locks dynamodb table.

All stacks try to create the table simultaneously resulting in some failing.

[2024-01-19T11:11:32 #20464 terraspace up s3_buckets]: Creating dynamodb table: terraform_locks
[2024-01-19T11:11:33 #20464 terraspace up s3_buckets]: Exception Aws::DynamoDB::Errors::ResourceInUseException: Attempt to change a resource which is still in use: Table is being created: terraform_locks

This is with plugin version 0.6.1

Would it be appropriate to interpolate the stack name into the table name here somehow?

terraspace_plugin_aws/lib/templates/ruby/project/config/terraform/backend.rb.tt

Line 9 in b2d749b

dynamodb_table: "terraform_locks"

(I was thinking perhaps append _:MOD_NAME, but maybe that causes issues if the stack name contains incompatible characters and is also maybe problematic when :MOD_NAME is a module and not a stack???)

[alexjfisher]

At the moment, I've gone with

<%- dynamodb_table = expansion(':TYPE') == 'stack' ? "terraform_locks_#{expansion(':MOD_NAME')}" : 'terraform_locks' %>
terraform {
  backend "s3" {
    bucket         = "<%= expansion('terraform-state-:ACCOUNT-:REGION-:ENV') %>"
    key            = "<%= expansion(':PROJECT/:REGION/:APP/:ROLE/:ENV/:EXTRA/:BUILD_DIR/terraform.tfstate') %>"
    region         = "<%= expansion(':REGION') %>"
    dynamodb_table = "<%= dynamodb_table %>"
  }
}

Seems to work ok.