Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with session (MaxAge == 0) cookie #53

Open
harperj1029 opened this issue Nov 14, 2018 · 1 comment
Open

Problem with session (MaxAge == 0) cookie #53

harperj1029 opened this issue Nov 14, 2018 · 1 comment

Comments

@harperj1029
Copy link

The change made in this commit appears to cause issues when trying to create session (non-durable) cookies. So now, when trying to set MaxAge = 0 (so that the cookie is session-only and doesn't live on), then it's instead deleted, and then set with an empty value. The result is an inability to have a session without having a persisted cookie.

NOTE: We use echo sessions in our project, which through dependencies, uses redistore. Some work-around was followed to pin go dep to use the master branch of redistore, rather than an older version.

@jon-mckinney
Copy link

Agreed, we're having the same issue noted by @harperj1029 above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants