Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages swallowed #86

Open
andig opened this issue Dec 30, 2022 · 0 comments
Open

Error messages swallowed #86

andig opened this issue Dec 30, 2022 · 0 comments

Comments

@andig
Copy link
Collaborator

andig commented Dec 30, 2022

Whenever we receive a non-200 response, the response JSON is ignored and any contained error swallowed:

HTTP/2.0 408 Request Timeout
Content-Length: 106
Cache-Control: no-cache, no-store, private, s-max-age=0
Content-Type: application/json; charset=utf-8
Date: Fri, 30 Dec 2022 15:46:15 GMT
Server: envoy
Strict-Transport-Security: max-age=31536000; includeSubDomains
Vary: Accept
X-Content-Type-Options: nosniff
X-Envoy-Upstream-Cluster: owner-api
X-Envoy-Upstream-Service-Time: 35
X-Frame-Options: DENY
X-Request-Id: 607ca386-1396-48f4-8846-26ae6d5cf866
X-Txid: 443ce41d67afee316399a80eefb2243d
X-Xss-Protection: 1; mode=block

{"response":null,"error":"vehicle unavailable: {:error=>\"vehicle unavailable:\"}","error_description":""}

Will only ever return the HTTP 408 although the code seems to suggest that we're actually decoding the error (which itself is json encoded as string...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant