Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small discrepancies between locally knitted pdf and published fig 2 #3

Open
annakrystalli opened this issue Feb 25, 2020 · 1 comment

Comments

@annakrystalli
Copy link

Hi!

I've been working on your paper as part of the Liverpool N8 CIR ReproHack. Thanks for submitting it! It's been really fun to work with.

I'm just finding small differences figure 2.

Here's the published plot

And here's what I'm getting when knitting the pdf:
Screenshot 2020-02-25 at 15 15 54

@cboettig
Copy link
Member

Cool, thanks for reporting.

The core sarsop algorithm which underlies this (https://github.com/boettiger-lab/sarsop) is actually a stand-alone C++ program that does not integrate into R's random number generator (yes it's a form of optimization algorithm but isn't entirely deterministic). I believe a degree of variability in sarsop is expected. Of course, this should impact the POMDP solution only.

I'm actually not sure of the top of my head if seed is being locked for the simulations underneath all three scenarios (recall these results are the combination of a decision rule and then simulations of the underlying process). I may not enforced random seed at all, or perhaps appropriately across the parallel processing. In any event, the qualitative result should be robust to seed, so that at least is good to see!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants