You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
And then the From implementations would just set an Integer or Float. This would be nice because it means that numbers (which account for a lot of possible values) never have to allocate.
Doing deref to str wouldn't be the best thing with this change. Something like as_string() -> String might be better suited.
The text was updated successfully, but these errors were encountered:
Thank you! I don't remember all the details off the top of my head, but that seems very much reasonable. If you want and have time, you could give it a try. I would be happy to review the PR.
IvanUkhov
changed the title
Change Value to an enum
Avoid string conversion when working with ValueJul 22, 2023
Rather than having
Value
always be aString
, something like this could be better:And then the
From
implementations would just set anInteger
orFloat
. This would be nice because it means that numbers (which account for a lot of possible values) never have to allocate.Doing
deref
tostr
wouldn't be the best thing with this change. Something likeas_string() -> String
might be better suited.The text was updated successfully, but these errors were encountered: