Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit names of PyDough operators to potentially standardize some of them #204

Open
knassre-bodo opened this issue Jan 10, 2025 · 0 comments
Labels
documentation Improvements or additions to documentation effort - low quick & simple issue refactor improving the quality of PyDough code user feature Adding a new user-facing feature/functionality

Comments

@knassre-bodo
Copy link
Contributor

knassre-bodo commented Jan 10, 2025

The names of PyDough operators can vary between being Pythonic, SQL-esque, or rooted in a phrasing that would be used in the text for an analytical question. Goal of this issue is to go through all the operator names and decide if any should be changed (in any of those 3 directions). Examples:

  • PRESENT / ABSENT is textual (could be NOTNA / ISNA which is pythonic, or IS_NOT_NULL / IS_NULL which is SQL-esuqe)
  • JOIN_STRINGS is Pythonic (could be CONCAT_WS which is SQL-esque)
  • DEFAULT_TO is textual (could be COALESCE which is SQL-esuqe, or FILLNA which is Pythonic)
  • LIKE is SQL-esuqe (could be MATCHES_PATTERN which is textual)
  • ISIN is Pythonic (could be IN which is more SQL-esque or CONTAINED_BY which is more textual)
  • ABS is SQL-esque/Pythonic (could be ABSOLUTE_VALUE which is more textual)
  • MONOTONIC is Pythonic (could be BETWEEN which is SQL-esque, or ASCENDING which is more textual)'
  • KEEP_IF is textual (could be NULL_UNLESS which is closer to SQL-esque, or MASK which is more Pythonic)
@knassre-bodo knassre-bodo added documentation Improvements or additions to documentation user feature Adding a new user-facing feature/functionality effort - low quick & simple issue refactor improving the quality of PyDough code labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation effort - low quick & simple issue refactor improving the quality of PyDough code user feature Adding a new user-facing feature/functionality
Projects
None yet
Development

No branches or pull requests

1 participant